Skip to content

Fix typos , format and grammar #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 6, 2025
Merged

Fix typos , format and grammar #21

merged 20 commits into from
Jun 6, 2025

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Apr 22, 2025

Mainly fixes typos , format and grammar.
Every chapter gets its own commit for easier merging resp. adjusting the commits.
Commits can also be squashed if that makes it suitable.

@dr0i dr0i requested a review from TobiasNx April 22, 2025 14:59
@dr0i dr0i added this to Metafacture Apr 22, 2025
@dr0i dr0i moved this to Review in Metafacture Apr 22, 2025
@TobiasNx
Copy link
Collaborator

@dr0i thanks a lot for your adjustments. I agree to almost all of them. There were some changes for fix -> Fix which were not correct in the playground links. And there are two open comments above. Otherwise +1 Thanks again.

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx May 15, 2025
@dr0i
Copy link
Member Author

dr0i commented May 22, 2025

I got through all links and fixed some.
Two problems remain:

  1. The part result in docs/05-More-Fix-Concepts.html seems not to be what's been talked about.

  2. the last Playground-link is no link but plain URL and the Flow doesn't work if copied to the browser

@dr0i
Copy link
Member Author

dr0i commented Jun 5, 2025

How to proceed @TobiasNx ? You could give a +1 and we merge and open new issue regarding my last comment or we/you fix/reject what I noted there.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Jun 5, 2025
@TobiasNx
Copy link
Collaborator

TobiasNx commented Jun 6, 2025

+1. Yes we should open new tickets for these bugs.

@dr0i dr0i merged commit 7fb0b04 into main Jun 6, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture Jun 6, 2025
@dr0i dr0i deleted the improveABit branch June 6, 2025 12:47
@dr0i dr0i mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants